Backout D82236159: [RN][debugger-shell] Implement saved window positioning per targe#53816
Closed
motiz88 wants to merge 1 commit into
Closed
Backout D82236159: [RN][debugger-shell] Implement saved window positioning per targe#53816motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
facebook-github-bot
added
fb-exported
meta-exported
p: Facebook
motiz88
force-pushed
the
export-D82632937
branch
from
34a8a19 to
3b8fd72
Compare
Contributor
motiz88
force-pushed
the
export-D82632937
branch
from
3b8fd72 to
afe010d
Compare
Contributor
motiz88
force-pushed
the
export-D82632937
branch
from
afe010d to
64fbc0e
Compare
Contributor
…oning per target (react#53816) Summary: Changelog: [Internal] D82236159 introduced the first `node_modules` dependency in the Electron part of `react-native/debugger-shell`. This is not currently handled correctly by the build script, so this resulted in an instacrashing binary. I'm temporarily backing out D82236159 until we have a proper fix for the build script. Reviewed By: robhogan Differential Revision: D82632937
motiz88
force-pushed
the
export-D82632937
branch
from
64fbc0e to
a1db610
Compare
Contributor
Contributor
|
This pull request has been merged in e16b647. |
Collaborator
|
This pull request was successfully merged by @motiz88 in e16b647 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
D82236159 introduced the first
node_modulesdependency in the Electron part ofreact-native/debugger-shell. This is not currently handled correctly by the build script, so this resulted in an instacrashing binary.I'm temporarily backing out D82236159 until we have a proper fix for the build script.
Differential Revision: D82632937