Skip to content

Use the Hermes artifacts in actions#53837

Closed
j-piasecki wants to merge 3 commits into
react:mainfrom
j-piasecki:export-D82721725
Closed

Use the Hermes artifacts in actions#53837
j-piasecki wants to merge 3 commits into
react:mainfrom
j-piasecki:export-D82721725

Conversation

@j-piasecki

@j-piasecki j-piasecki commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Summary: Changelog: [Internal]

Differential Revision: D82721725

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2025
@facebook-github-bot facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 18, 2025
@facebook-github-bot

facebook-github-bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating diff in D82721725.

@facebook-github-bot

facebook-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82721725.

@meta-codesync

meta-codesync Bot commented Oct 16, 2025

Copy link
Copy Markdown

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D82721725.

@j-piasecki j-piasecki force-pushed the export-D82721725 branch 3 times, most recently from 565ab26 to 04e2733 Compare October 17, 2025 08:52
cortinico
cortinico approved these changes Oct 17, 2025
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@j-piasecki j-piasecki force-pushed the export-D82721725 branch 8 times, most recently from e91e496 to 1f54ff4 Compare October 22, 2025 09:31
@j-piasecki @facebook-github-bot
Update release processes to update the Hermes versions independently …
e9bde4e 
…from React Native (#53985)

Summary:

Changelog: [Internal]

Updates the release scripts to set the Hermes version independently from React Native.

Reviewed By: cipolleschi

Differential Revision: D82438054
@j-piasecki @facebook-github-bot
Always use Hermes artifacts published from Hermes repository (#53833)
fc5866e 
Summary:

Changelog: [GENERAL][CHANGED] - Use Hermes artifacts published independently from React Native

Reviewed By: cortinico

Differential Revision: D82626463
@j-piasecki @facebook-github-bot
Use the Hermes artifacts in actions (#53837)
bf53eba 
Summary:

Changelog: [Internal]

Replaces usage of Hermes built inside the React Native repository with the release published from the Hermes repo.

Differential Revision: D82721725
@meta-codesync meta-codesync Bot closed this in e3287d9 Oct 22, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 22, 2025
@meta-codesync

meta-codesync Bot commented Oct 22, 2025

Copy link
Copy Markdown

This pull request has been merged in e3287d9.

@alanjhughes alanjhughes mentioned this pull request Apr 20, 2026
Closed
meta-codesync Bot pushed a commit that referenced this pull request Apr 21, 2026
@alanjhughes @meta-codesync
Skip use-hermes-nightly when hermes-compiler is already pinned (#56505)
70281d6 
Summary:
`use-hermes-nightly` unconditionally overwrites the `hermes-compiler` with whatever the `latest-v1` tag currently points to. On release branches, where `hermes-compiler` is pinned to a specific version, it replaces the pin. This doesn't cause an issue until the `latest-v1` tag moves off the pinned version.

Looks to have been introduced by #53837.

bypass-github-export-checks

## Changelog:

[INTERNAL] [FIXED] - Preserve pinned `hermes-compiler` version when running `use-hermes-nightly` on release branches.

Pull Request resolved: #56505

Test Plan: With `hermes-compiler` manually set to a real version, the script returns early without modifying `package.json` or `hermes-engine/version.properties`.

Reviewed By: cortinico

Differential Revision: D101633376

Pulled By: cipolleschi

fbshipit-source-id: 666baa1a7838272b18e326b8597394d66b81343c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-piasecki @facebook-github-bot @cortinico