Use nightly Hermes by default when building in OSS#54864
Closed
j-piasecki wants to merge 2 commits into
Closed
Conversation
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89042837. |
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D89042837
branch
2 times, most recently
from
0b70705 to
0747b8d
Compare
Summary: Changelog: [Internal] Reviewed By: cortinico Differential Revision: D87929652
Summary: Changelog: [Internal] Changes the default behavior for local iOS builds inside the monorepo to use the nightly hermes version (if set) instead of building from source. If build from source is needed, it's possible to force by using `RCT_BUILD_HERMES_FROM_SOURCE` env variable. Reviewed By: cipolleschi Differential Revision: D89042837
j-piasecki
force-pushed
the
export-D89042837
branch
from
0747b8d to
1d1acdd
Compare
|
This pull request has been merged in 66d1ec0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Changes the default behavior for local iOS builds inside the monorepo to use the nightly hermes version (if set) instead of building from source.
If build from source is needed, it's possible to force by using
RCT_BUILD_HERMES_FROM_SOURCEenv variable.Differential Revision: D89042837