Skip to content

Enable hermesV1Enabled=true by default on Android#55040

Closed
cortinico wants to merge 3 commits into
mainfrom
nc/hermesV1Enabled-defaulttrue
Closed

Enable hermesV1Enabled=true by default on Android#55040
cortinico wants to merge 3 commits into
mainfrom
nc/hermesV1Enabled-defaulttrue

Conversation

@cortinico

Copy link
Copy Markdown
Contributor

Summary:

This PR enables the hermesV1Enabled flag by default for Android.
Users will still be able to turn off the flag if they wish to revert to legacy Hermes.

Changelog:

[ANDROID] [CHANGED] - Enable hermesV1Enabled by default on Android, which turns on Hermes V1 (Static Hermes) by default

Test Plan:

CI

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@cipolleschi

Copy link
Copy Markdown
Contributor

is this automatically download the right version of Hermes? because I think you also need the changes I have on #54989 where we update the version.properties file

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: build_android
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github publishAllToMavenTempLocal build 9.0.0 Build Scan not published

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@meta-codesync

meta-codesync Bot commented Jan 5, 2026

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D90129971.

@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@github-actions

github-actions Bot commented Jan 6, 2026

Copy link
Copy Markdown

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 Build Scan not published

@cortinico

Copy link
Copy Markdown
Contributor Author

Closing as this has been picked inside:

@cortinico cortinico closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants