fix(react-native): add prefabPublishing to hermes-engine for build-from-source#55310
Closed
chrfalch wants to merge 1 commit into
Closed
fix(react-native): add prefabPublishing to hermes-engine for build-from-source#55310chrfalch wants to merge 1 commit into
chrfalch wants to merge 1 commit into
Conversation
…om-source PR #54707 removed `prefabPublishing = true` from hermes-engine when switching to prebuilt Hermes by default. This broke build-from-source because AGP no longer generates the CMake config file needed by `find_package(hermes-engine)` in ReactAndroid's native build. Adding `prefabPublishing = true` back restores the CMake config generation and proper Gradle task ordering. The same PR also disables all hermes tasks when not building from source - which will make the CI work correctly - ie. not build hermes from source when not needed.
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
j-piasecki
approved these changes
Jan 27, 2026
Contributor
|
@chrfalch can you open a pick request for this one please? |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D91581389. |
|
@cortinico merged this pull request in e8eb374. |
alanleedev
pushed a commit
that referenced
this pull request
Jan 29, 2026
…om-source (#55310) Summary: PR #54707 removed `prefabPublishing = true` from hermes-engine when switching to prebuilt Hermes by default. This broke build-from-source because AGP no longer generates the CMake config file needed by `find_package(hermes-engine)` in ReactAndroid's native build. Adding `prefabPublishing = true` back restores the CMake config generation and proper Gradle task ordering. The same PR also disables all hermes tasks when not building from source - which will make the CI work correctly - ie. not build hermes from source when not needed. ## Changelog: [ANDROID] [FIXED] - Re-added prefabPublishing=true to make Android build from source work again Pull Request resolved: #55310 Test Plan: - Build RN Tester and build from source, verify that Android builds correctly. - Check CI and verify that Hermes is not built from source Reviewed By: cipolleschi Differential Revision: D91581389 Pulled By: cortinico fbshipit-source-id: 01953cc071d22faa84920ebe30cc1426c8d420e4
Collaborator
|
This pull request was successfully merged by @chrfalch in 8206c12 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #54707 removed
prefabPublishing = truefrom hermes-engine when switching to prebuilt Hermes by default. This broke build-from-source because AGP no longer generates the CMake config file needed byfind_package(hermes-engine)in ReactAndroid's native build.Adding
prefabPublishing = trueback restores the CMake config generation and proper Gradle task ordering.The same PR also disables all hermes tasks when not building from source - which will make the CI work correctly - ie. not build hermes from source when not needed.
Closes #55290
Changelog:
[ANDROID] [FIXED] - Re-added prefabPublishing=true to make Android build from source work again
Test Plan: