fix: inability to disable hermesV1 on Android#55399
Closed
tjzel wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
cortinico
approved these changes
Feb 4, 2026
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D92267385. |
Collaborator
|
This pull request was successfully merged by @tjzel in 4589667 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico merged this pull request in 4589667. |
react-native-bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
Summary: Changing the line in `ReactPlugin.kt` that always set `hermesV1Enabled` to `true` even if it was explicitly disabled, accidentally omitted in #54989. In recent update of hermes V1 binary a file `RuntimeAdapter.h` was removed. ## Changelog: [ANDROID] [FIXED] - ReactPlugin.kt always setting `hermesV1Enabled` to `true` Pull Request resolved: #55399 Test Plan: Build React Native from source on latest 0.84 RC, disable hermesV1 and see that it compiles now. Reviewed By: cipolleschi Differential Revision: D92267385 Pulled By: cortinico fbshipit-source-id: 58ecae6d3064995ef9e63ddbd67ac04db2a1126b
Collaborator
|
This pull request was successfully merged by @tjzel in 83a038d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changing the line in
ReactPlugin.ktthat always sethermesV1Enabledtotrueeven if it was explicitly disabled, accidentally omitted in #54989.In recent update of hermes V1 binary a file
RuntimeAdapter.hwas removed.Changelog:
[ANDROID] [FIXED] - ReactPlugin.kt always setting
hermesV1EnabledtotrueTest Plan:
Build React Native from source on latest 0.84 RC, disable hermesV1 and see that it compiles now.