Fix strict transform array element type - #57908
Open
Boulea7 wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
facebook-github-tools
Bot
added
the
Shared with Meta
huntie
reviewed
Aug 12, 2026
Boulea7
force-pushed
the
fix/react-native-strict-api-transform
branch
from
August 12, 2026 18:37
848cb39 to
6c27484
Compare
Boulea7
force-pushed
the
fix/react-native-strict-api-transform
branch
from
August 12, 2026 18:41
6c27484 to
66b3f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #53899.
MergeUnionmade every transform key optional beforeMaximumOneOfselected a key. Indexing that optional mapped type addedundefinedto each element ofViewStyle['transform']under strict null checks. This makes the intermediate keys required, preserving the existing one-key transform constraint while keepingundefinedout of the array element type.Changelog:
[General] [Fixed] - Prevent strict transform array element types from including undefined
Test Plan:
yarn test-generated-typescriptyarn test-typescript-legacyyarn build-types --validateyarn flow-check --max-workers 8 --show-all-errors(0 errors)yarn lintyarn test scripts/js-api --runInBand(22 suites, 153 tests passed)git diff --check