Fix bug with cross-axis alignment when there is space between lines#1993
Open
janarve wants to merge 1 commit into
Open
Fix bug with cross-axis alignment when there is space between lines#1993janarve wants to merge 1 commit into
janarve wants to merge 1 commit into
Conversation
The code adds the space between the lines to the lineHeight by: lineHeight += crossDimLead; *before* the item alignment happens, this will fail for center and end alignment (it will extend too far in the cross-axis) We therefore need to compensate for that for those two align-item cases. This happened with the combination of align-items: center (or flex-end) align-content: space-between (or space-around) flex-wrap: wrap (flexbox width needs to be small enough to trigger wrapping)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code adds the space between the lines to the lineHeight by:
before the item alignment happens, this will fail for center and end alignment (it will extend too far in the cross-axis)
We therefore need to compensate for that for those two align-item cases.
This happened with the combination of
align-items: center (or flex-end)
align-content: space-between (or space-around)
flex-wrap: wrap
(flexbox width needs to be small enough to trigger wrapping)