Repository navigation
fix: cronjob: respect environment and nexttime for idle jobs - #6739
Merged
Merged
Conversation
The OR added for the nullable execution_start column lacked parentheses, so AND bound tighter and every active, idle job matched regardless of environment and due time.
gharlan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
execution_start IS NULL OR …condition introduced in #6057 was missing parentheses. SinceANDbinds tighter thanOR, every active job withexecution_start IS NULL(i.e. the normal idle state) matched regardless ofenvironmentandnexttime:cronjob:runexecuted all active jobs on every call, due or notscriptalso ran in frontend/backend5.x is not affected (
execution_startis not nullable there).