implementing the fixes that claude suggested#238
Open
djdanielsson wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I don't understand the issue it is finding because when I run pre-commit locally there is no issue. I think we ignore that but look at the other stuff |
djdanielsson
requested review from
Tompage1994 and
sean-m-sullivan
and removed request for
Tompage1994
Contributor
Author
|
@sean-m-sullivan @Tompage1994 thoughts? |
Contributor
|
I think the changes are fine, mainly nitpicking and cleaning things up, but still have we tested the changes? |
djdanielsson
force-pushed
the
claude_improvements
branch
from
f671a00 to
a88d80e
Compare
ansible-core devel now requires Python >=3.13, making the sanity-py3.12-devel tox environment incompatible. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
something I figured I would try and reviewing them, seem like over all decent fixes but would like reviews on this and need to test it fully before merging