feat: add ack-secretsmanager-controller#413
feat: add ack-secretsmanager-controller#413tim-stasse wants to merge 1 commit intoredhat-cop:mainfrom
Conversation
tim-stasse
requested review from
gnunn1,
pittar and
strangiato
as code owners
| kind: Subscription | ||
| metadata: | ||
| name: ack-secretsmanager-controller | ||
| namespace: ack-system |
There was a problem hiding this comment.
This should probably include the creation of the namespace
There was a problem hiding this comment.
Namespace creation is in ack-system folder, which this depends on. I'm simply following the existing convention from ack-s3-controller, etc
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - ../../base |
There was a problem hiding this comment.
Should the secret be included in the resources so it gets created, or is the intention just to show an example of the secret?
If it is intended to just be an example, can we add example to the name of the yaml file?
There was a problem hiding this comment.
Same as above, this is simply a copy-paste from ack-s3-controller. Happy to add example to the name if there's strong opinions.
| name: ack-secretsmanager-user-secrets | ||
| namespace: ack-system |
There was a problem hiding this comment.
If this secret is intended to be added to the resources list, we should consider adding the namespace: ack-system to the kustomize file as well.
2 participants
No description provided.