fix(makefile): Improve performance of make lint#1059
fix(makefile): Improve performance of make lint#1059olivergondza wants to merge 1 commit intoredhat-developer:masterfrom
Conversation
|
/retest |
|
Can we move on with this? It was merged in the upstream operator already. |
|
Hi @svghadi , I don't have write access to this repo - adding you to review and approve. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bbe0cf7 to
acbb81d
Compare
|
Rebased to merge cleanly. PTAL, @svghadi |
|
/lgtm |
|
This should not influence the test execution in any way... |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
acbb81d to
3c44c3b
Compare
|
New changes are detected. LGTM label has been removed. |
|
@olivergondza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
Same change now done in argo-cd: argoproj/argo-cd#26025
What does this PR do / why we need it:
lint is sped up from 46s to 15s
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: