Skip to content

backport 1.10 - fix(lightspeed): pre-create /rag-content/vector_db/notebooks in init … #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JslYoon wants to merge 9 commits into
base: release-1.10
Choose a base branch
from
+10 −6
Open

backport 1.10 - fix(lightspeed): pre-create /rag-content/vector_db/notebooks in init … #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aee5c8a
fix(lightspeed): pre-create /rag-content/vector_db/notebooks in init …
JslYoon Jun 22, 2026
d500e6b
Update charts/backstage/values.yaml
JslYoon Jun 23, 2026
f65c857
Update charts/backstage/values.yaml
JslYoon Jun 23, 2026
0caaa25
fix duplication and lint
JslYoon Jun 23, 2026
810aab8
chore(backstage): bump chart to 5.12.5, regenerate schema and docs
JslYoon Jun 23, 2026
9ad9e2f
chore: revert non-backstage README regeneration
JslYoon Jun 23, 2026
47df148
chore(backstage): fix README maintainer URL and dependency alias format
JslYoon Jun 23, 2026
fcc0a0c
fix(backstage): restore upstream.backstage structure corrupted by spu…
JslYoon Jun 23, 2026
5aa9e3a
chore(backstage): regenerate README and schema after upstream.backsta…
JslYoon Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ sources: []
# Versions are expected to follow Semantic Versioning (https://semver.org/)
# Note that when this chart is published to https://github.com/openshift-helm-charts/charts
# it will follow the RHDH versioning 1.y.z
version: 5.12.4
version: 5.12.5
4 changes: 2 additions & 2 deletions charts/backstage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

# RHDH Backstage Helm Chart for OpenShift

![Version: 5.12.4](https://img.shields.io/badge/Version-5.12.4-informational?style=flat-square)
![Version: 5.12.5](https://img.shields.io/badge/Version-5.12.5-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub, which is a Red Hat supported version of Backstage.
Expand Down Expand Up @@ -29,7 +29,7 @@ For the **Generally Available** version of this chart, see:
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add redhat-developer https://redhat-developer.github.io/rhdh-chart

helm install my-backstage redhat-developer/backstage --version 5.12.4
helm install my-backstage redhat-developer/backstage --version 5.12.5
```

## Introduction
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
"enabled": true,
"initContainer": {
"args": [
"mkdir -p /tmp/data && echo 'Copying Lightspeed RAG data...' && cp -r /rag/vector_db /rag-content/ && cp -r /rag/embeddings_model /rag-content/ && echo 'Copy complete.'"
"mkdir -p /tmp/data && echo 'Copying Lightspeed RAG data...' && cp -r --no-preserve=mode,ownership /rag/vector_db /rag-content/ && cp -r --no-preserve=mode,ownership /rag/embeddings_model /rag-content/ && mkdir -p /rag-content/vector_db/notebooks && chmod -R a+rwX /rag-content && echo 'Copy complete.'"
],
"command": [
"sh",
Expand Down
8 changes: 6 additions & 2 deletions charts/backstage/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,10 @@ global:
- >-
mkdir -p /tmp/data &&
echo 'Copying Lightspeed RAG data...' &&
cp -r /rag/vector_db /rag-content/ &&
cp -r /rag/embeddings_model /rag-content/ &&
cp -r --no-preserve=mode,ownership /rag/vector_db /rag-content/ &&
cp -r --no-preserve=mode,ownership /rag/embeddings_model /rag-content/ &&
mkdir -p /rag-content/vector_db/notebooks &&
chmod -R a+rwX /rag-content &&

@rm3l rm3l Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
chmod -R a+rwX /rag-content &&
chmod -R a+rwX /rag-content/vector_db /rag-content/embeddings_model &&

Should chmod the specific subdirectories IMO if you are changing the permissions.

echo 'Copy complete.'
env: []
# -- Resource requests/limits for the Lightspeed RAG bootstrap init container.
Expand Down Expand Up @@ -193,6 +195,8 @@ upstream:
repository: rhdh-community/rhdh
tag: next-1.10
pullPolicy: ""
podSecurityContext:
enabled: false
Comment on lines +198 to +199

@rm3l rm3l Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
podSecurityContext:
enabled: false

There is no such enabled field in the upstream chart. This is confirmed in CI:

W0623 19:15:22.527918   18101 warnings.go:70] unknown field "spec.template.spec.securityContext.enabled"
Error: UPGRADE FAILED: timed out waiting for the condition

@rm3l rm3l Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And with only the fsGroup set, you can also remove thse two lines IMO from CI:

rhdh-chart/.github/actions/test-charts/action.yml

Lines 169 to 170 in e767157

"--set upstream.backstage.podSecurityContext.runAsUser=1001"
"--set upstream.backstage.podSecurityContext.runAsGroup=1001"

command: []
# FIXME (tumido): USE POSTGRES_PASSWORD and POSTGRES_USER instead of POSTGRES_ADMIN_PASSWORD
# This is a hack. In {fedora,rhel}/postgresql images, regular user is forbidden
Expand Down
Loading