Repository navigation
fix(ci): run prettier on Yarn bump diffs before commit - #132
Merged
Merged
Conversation
Yarn writes double quotes in .yarnrc.yml; repos with prettier:check reject that and fail CI. Format the changed files when the repo defines a prettier script, using a shellcheck-clean file list. https://redhat.atlassian.net/browse/RHIDP-17563 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Finished Review · ✅ Success · Started 9:20 PM UTC · Completed 9:33 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.52 |
|
Review skipped — this PR is already merged. The Posted by fullsend pre-review check |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn-bump.shcommits, runyarn prettier --ignore-unknown --writeon the changed files when the repo definesprettier:checkorprettier:fix."**"in.yarnrc.yml; Prettier (rhdh-cli) requires'**', which failed rhdh-cli #236.while readloop soshellcheck --severity=warningstays clean (skills CI already runs that check).Test plan
bash -n skills/ci/rhdh-yarn-bump/scripts/yarn-bump.shshellcheck --severity=warning skills/ci/rhdh-yarn-bump/scripts/yarn-bump.shprettier:checkformats.yarnrc.ymlbefore the PR opensRef: https://redhat.atlassian.net/browse/RHIDP-17563
Generated-by: cursor