Skip to content

Add --pids-limit=-1 to podman run commands in PerfCI Jenkinsfile#1250

Open
ebattat wants to merge 1 commit into
mainfrom
fix-podman-pids-limit
Open

Add --pids-limit=-1 to podman run commands in PerfCI Jenkinsfile#1250
ebattat wants to merge 1 commit into
mainfrom
fix-podman-pids-limit

Conversation

@ebattat

@ebattat ebattat commented Jun 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Add --pids-limit=-1 to all 3 podman run commands in the PerfCI workloads deployment Jenkinsfile
  • Prevents transient failed to create new OS thread (errno=11) errors

Problem

When running hammerdb_vm_mssql_scale (6 VMs), virtctl ssh polls all VMs in parallel. Each virtctl ssh spawns Go threads. If leftover processes from a previous workload run haven't fully cleaned up, the container hits its PID limit:

virtctl ssh failed: runtime: failed to create new OS thread (have 15 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

Fix

Add --pids-limit=-1 to remove the container PID limit for all podman run commands:

  • Main workload run (line 186)
  • Bootstorm warm-up run (line 146)
  • Windows warm-up run (line 164)

Test plan

  • Second run without fix succeeded (confirms transient nature)
  • Verify no recurrence with --pids-limit=-1

🤖 Assisted-by: Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved workload deployment reliability by removing process-limit restrictions on container runs.
    • Reduced the chance of deployment failures during warm-up and workload execution stages.

Prevents 'failed to create new OS thread (errno=11)' errors when
virtctl ssh polls multiple VMs in parallel and hits the container
PID limit.

Assisted-by: Claude Code
@openshift-ci openshift-ci Bot requested a review from RobertKrawitz June 28, 2026 05:24
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 92bc5a16-0973-42a9-bf01-a227a310282f

📥 Commits

Reviewing files that changed from the base of the PR and between 9e805c1 and 1d84d91.

📒 Files selected for processing (1)
  • jenkins/PerfCI/03_PerfCI_Workloads_Deployment/Jenkinsfile

📝 Walkthrough

Walkthrough

Three sudo podman run commands in the WORKLOADS Deployment stage of the Jenkinsfile are updated to include --pids-limit=-1: the warm-up container for bootstorm_vm_scale, the warm-up container for windows_vm, and the main per-workload container launch.

Changes

Add --pids-limit=-1 to Podman container launches

Layer / File(s) Summary
Add --pids-limit=-1 to all podman run invocations
jenkins/PerfCI/03_PerfCI_Workloads_Deployment/Jenkinsfile
--pids-limit=-1 added to the bootstorm_vm_scale warm-up, windows_vm warm-up, and main per-workload podman run commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding --pids-limit=-1 to podman run commands in the PerfCI Jenkinsfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-podman-pids-limit

Comment @coderabbitai help to get the list of available commands.

@ebattat ebattat requested a review from arpsharm June 28, 2026 05:25
@ebattat ebattat self-assigned this Jun 28, 2026
@ebattat ebattat added the bug Something isn't working label Jun 28, 2026
@github-project-automation github-project-automation Bot moved this to In progress in benchmark-runner Jun 28, 2026
@openshift-ci

openshift-ci Bot commented Jun 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arpsharm, ebattat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bug Something isn't working lgtm

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants