Add --pids-limit=-1 to podman run commands in PerfCI Jenkinsfile#1250
Add --pids-limit=-1 to podman run commands in PerfCI Jenkinsfile#1250ebattat wants to merge 1 commit into
Conversation
Prevents 'failed to create new OS thread (errno=11)' errors when virtctl ssh polls multiple VMs in parallel and hits the container PID limit. Assisted-by: Claude Code
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThree ChangesAdd --pids-limit=-1 to Podman container launches
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arpsharm, ebattat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
--pids-limit=-1to all 3 podman run commands in the PerfCI workloads deployment Jenkinsfilefailed to create new OS thread (errno=11)errorsProblem
When running
hammerdb_vm_mssql_scale(6 VMs),virtctl sshpolls all VMs in parallel. Eachvirtctl sshspawns Go threads. If leftover processes from a previous workload run haven't fully cleaned up, the container hits its PID limit:Fix
Add
--pids-limit=-1to remove the container PID limit for all podman run commands:Test plan
--pids-limit=-1🤖 Assisted-by: Claude Code
Summary by CodeRabbit