test: consolidate message/snapshot builders into shared support module - #18
Merged
Merged
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
CodeAnt Nitpicks2 code suggestions1. Omitting
|
ForeverInLaw
force-pushed
the
simplify/test-consolidate
branch
from
September 21, 2026 23:21
d790a78 to
b3f4eeb
Compare
ForeverInLaw
force-pushed
the
simplify/ui-simplify
branch
2 times, most recently
from
September 21, 2026 23:42
7a12881 to
2178b6d
Compare
ForeverInLaw
force-pushed
the
simplify/test-consolidate
branch
from
September 21, 2026 23:42
b3f4eeb to
3b8cddb
Compare
Thirteen test files carried their own private _msg/_snapshot builders - the same ChatMessage/GroupMessage/ChannelMessage and SessionSnapshot/ GroupSnapshot/ChannelSnapshot null-defaulted boilerplate written out per file. One shared module (test/support/message_builders.dart, TestMessages + TestSnapshots + TestCalls) now owns them; each test file imports it and keeps at most a thin named-arg shim where its defaults differed. No test names, assertions, or coverage changed. Net -346 lines across the 13 files; the shared file amortizes across every future test. flutter analyze clean, all 838 tests pass.
ForeverInLaw
force-pushed
the
simplify/test-consolidate
branch
from
September 22, 2026 01:33
3b8cddb to
d231573
Compare
ForeverInLaw
force-pushed
the
simplify/ui-simplify
branch
from
September 22, 2026 01:33
2178b6d to
662f5a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Problem
Thirteen test files carried private copies of the same scaffolding: null-defaulted
ChatMessage/GroupMessage/ChannelMessagebuilders andSessionSnapshot/GroupSnapshot/ChannelSnapshotconstructors, written out per file.Change
One shared
test/support/message_builders.dart(TestMessages,TestSnapshots,TestCalls) owns the builders; each test file imports it and keeps at most a thin named-arg shim where its defaults differed. Net −346 lines across the 13 files; the shared file amortizes over every future test.No test names, assertions, or coverage changed.
Verification
flutter analyzeclean,dart format lib testcleanStack: PR 5/6 (on #17).
CodeAnt-AI Description
Centralize conversation and voice-call test data setup
What Changed
Impact
✅ Shorter test setup✅ Consistent conversation fixtures✅ Reliable voice-call lifecycle tests💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.