Skip to content

style: fix formatting (black + cargo fmt)#2

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/fix-formatting
Open

style: fix formatting (black + cargo fmt)#2
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/fix-formatting

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Overview:

Fix formatting issues flagged by CI on upstream PR ai-dynamo#10939.

Details:

  • black: Collapse multi-line RepetitionDetectionParams(**value) to single line in handlers.py
  • cargo fmt: Reformat matches! macro, anyhow::bail! macros, and assert_eq! in validate.rs and chat_completions.rs

Where should the reviewer start?

All changes are auto-formatter output — no logic changes.

Related Issues

🚫 This PR is NOT linked to an issue:

  • Confirmed — no related issue

Link to Devin session: https://app.devin.ai/sessions/f1910643f0cb4b90b9f8698f6b639810
Requested by: @raunakdoesdev

Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Raunak Chowdhuri <raunak@reducto.ai>
@raunakdoesdev raunakdoesdev self-assigned this Jun 24, 2026
@raunakdoesdev raunakdoesdev self-requested a review June 24, 2026 22:34
@devin-ai-integration

Copy link
Copy Markdown
Author
Original prompt from Raunak

SYSTEM:
=== BEGIN THREAD HISTORY (in #proj-modal-at-home) ===
Sravan Puttagunta (U0B0RDKAR3N): if you fix that issue, we should see maverick route to GPU as well

Jean Ghislain Billa (U08V1RU5R54): So repetition detection is a specific parameter than VLLM added to the OpenAI API. The NVIDIA dynamo frontend parser does not let the parameter through. A proper fix would require making a custom fork of nvidia dynamo and patching. I don't think it's worth the lift for now, I want to prioritize getting traffic in.
Currently, we only use it with key-value so I think it's okay to forego repetition detection for requests going to Dynamo for now: <https://github.com/reductoai/api/pull/7567|github.com/reductoai/api/pull/7567>. Maverick also has a super low repetition rate.
I will do a follow up on this if necessary in the future. @Sravan Puttagunta

<most_recent_message>
Raunak Chowdhuri (U0615F96QH2): @Devin is there a way to pass this in as additional arguments or something like that as an alternative here? I'm sure dynamo has some support for extra body or something like that no? can you take a look at the context and suggest something here
</most_recent_message>
=== END THREAD HISTORY ===

Thread URL: https://reductoai.slack.com/archives/C0B9PCXP874/p1782180596276739?thread_ts=1782180596.276739&amp;cid=C0B9PCXP874

The latest message is the one right above that tagged you. The <most_recent_message> is the message that you should use to guide your goals + task for this session, and you should use the rest of the slack thread as context.

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant