Correct agent harness and launcher lists in Plans docs - #42
Open
tpavlu wants to merge 2 commits into
Open
Conversation
Word-level pass toward simplified technical English. Swaps requires/required and previous for their plainer equivalents on lines this PR introduced. No technical content or product names changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Three docs pages restate, by hand, two lists that have exactly one source of truth in the product: the
LaunchAgentharness enum and the agent launcher order. Both restatements had drifted.multi-agent.mdxwas missing theconductor-cloudharness everywhere it should appear and described therepo/branch/modeloverrides as Cursor-only;integrations/overview.mdxandgetting-started/your-first-plan.mdxlisted different, incomplete sets of launchers, both omitting Claude Code Desktop and neither mentioning Orchestrate, which is the first entry in the Launch Agent menu. This PR makes all three pages match the code, documentsSendMessage'sfromAgentIdparameter, and stopsyour-first-plan.mdxfrom keeping its own copy of the launcher list.Verified
All claims checked in
ref-tools/ref:plan-app/server/src/utils/factoryToolHandlers.ts,LaunchAgentinputSchema.harness:['cursor', 'devin', 'ref-thread', 'warp-oz', 'conductor-cloud'];handleLaunchAgentre-validates the same five values.repo/branch/model— same file:repois described as "Repository override (Cursor / Conductor Cloud). When omitted, Cursor falls back to the user's configured repository (settings.cursor.repository); Conductor falls back to its configured project";branchandmodelare both "(for Cursor / Conductor Cloud)". Fallbacks confirmed inplan-app/server/src/services/agentLaunchService.ts(Cursor spreadsrepooversettings.cursor.repository) andplan-app/server/src/services/conductorLauncher.ts(createWorkspaceusesoverrides?.projectId ?? settings.projectId).agentLaunchService.tsthrowsConductor API key not configuredwhensettings.conductorCloud?.apiKeyis absent, alongside the equivalent Cursor/Devin/Warp OZ checks.conductorLauncher.tscreates a workspace then a session;agentService.tssyncsprUrlfor Cursor (data.prUrl), Devin (data.pull_request.url) and Warp OZ (PULL_REQUESTartifact) only, so the PR-URL claim in the harness selection guide is scoped to those three.SendMessage.fromAgentId—factoryToolHandlers.ts: optional, described as "Always pass your own agent ID here (yourAgentId). Defaults to current agent only in agent-scoped MCP sessions";handleSendMessagerejects a mismatchingfromAgentIdin agent-scoped sessions. The tool description also carries "Do NOT send a message to acknowledge receipt of another agent's message. Do not acknowledge an acknowledgement", now a bullet in the messaging rules.plan-app/shared/agentLauncherOrder.tsAGENT_LAUNCHER_ORDER: orchestrate, cursor-cloud, claude-web, codex-cloud, devin, warp-oz, conductor-cloud, cursor-local, codex-desktop, claude-code-desktop, conductor, factory, windsurf, zed, github-copilot, copy-clipboard.plan-app/client/src/types/readState.tsWEBHOOK_DESTINATIONS: claude-code-web, codex-cloud, cursor-local, copy-paste, codex-desktop, claude-code-desktop, conductor, factory, windsurf, zed, github-copilot — exactly the eleven rows in the launcher table.plan-app/client/src/utils/agentLauncherDisplay.tsx(Cursor Desktop, not "Cursor Local";Codex Cloud/Codex Desktop;Copy to clipboard, not "Copy & Paste";Claude Code Desktop).plan-app/client/src/utils/desktopAgentDeeplink.tsbuildscursor://,codex://,claude://code/new,conductor://,factory-desktop://,windsurf://cascade,zed://agent, andvscode://github.copilot-chat/chat?mode=agentURLs with the prompt embedded;CopyAndOpenLaunchPanel.tsxcopies the prompt and opensclaude.ai/codeorchatgpt.com/codex.AGENT_LAUNCHER_ORDER;plan-app/client/src/components/Header.tsxkeeps it visible regardless of the user's enabled agents ("Orchestrate is always available; it is not user-toggleable"). Delegates come fromplan-app/client/src/utils/orchestrate.tsxORCHESTRATE_DELEGATES(Cursor Cloud, Devin, Warp OZ, Conductor Cloud);buildKickoffPromptemits "Review every PR against the plan before sign-off" / "Do not merge; leave merging to a human", with review defaulting on (orchestrator?.reviewPrs !== false) and merge defaulting off and gated on a GitHub PAT (OrchestrateLaunchPanel.tsxdisables the merge checkbox without one).Unverified / omitted
LaunchAgentrequirements list. The launch path only hard-fails on a missing API key, so the requirements list names the API key only.repoaccepting either a git URL or a project id for Conductor Cloud. True in the launch path, but too narrow a detail for the parameter bullet; left for the Conductor Cloud integration page.plans/workflows/overview.mdxstill names only "(Cursor, Devin)" as implementation harnesses, andyour-first-plan.mdx's agent-setup tabs have no Conductor Cloud tab despite it being an API-key cloud agent. Neither file was in this change's scope.integrations/overview.mdxnow owns the launcher list andyour-first-plan.mdxlinks to it instead of repeating it. The harness list is still restated onplans/install/index.mdxandplans/workflows/multi-agent.mdx; consolidating those would mean restructuring the install page, so it is left alone.Conflicts
docs.jsonwas not touched, so no navigation conflicts with sibling PRs.plans/workflows/orchestrate.mdxdoes not exist onmain, somulti-agent.mdxdoes not link to it; a sibling PR adding that page may want to link it frommulti-agent.mdxand from the new Orchestrate section inplans/integrations/overview.mdx.Generated by Claude Code