Skip to content

update login route to be main page#1785

Merged
Alek99 merged 1 commit intomainfrom
update-login-route-to-be-main-page
Mar 18, 2026
Merged

update login route to be main page#1785
Alek99 merged 1 commit intomainfrom
update-login-route-to-be-main-page

Conversation

@adhami3310
Copy link
Member

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 18, 2026

Greptile Summary

This PR simplifies the "Sign In" button link in the marketing navbar from a specific /cloud-login?redirect_to=.../callback/ route to just the root REFLEX_BUILD_URL (https://build.reflex.dev/), reflecting a backend change where the main page now handles the authentication flow.

  • The old URL explicitly targeted a /cloud-login endpoint with a redirect_to callback parameter; no other occurrences of cloud-login exist in the codebase, confirming this was the sole reference.
  • The new URL points to REFLEX_BUILD_URL directly — consistent with how other links in the codebase (e.g., cta_card.py, plan_cards.py, final_cta.py) already reference this URL.
  • The change is minimal, intentional, and safe; the "Sign In" button behavior now relies on the main build page to handle unauthenticated users appropriately.

Confidence Score: 5/5

  • This PR is safe to merge — it is a single-line, intentional URL simplification with no logic errors or side effects.
  • The change is trivial: one URL string replaced with a pre-defined constant already used consistently throughout the codebase. No new logic is introduced, no security concerns, and no other files are affected.
  • No files require special attention.

Important Files Changed

Filename Overview
pcweb/views/marketing_navbar.py Simplifies the "Sign In" button link from a specific cloud-login route (with redirect_to callback) to the root REFLEX_BUILD_URL. One-line change, no logical issues.

Sequence Diagram

sequenceDiagram
    actor User
    participant NavBar as Marketing Navbar
    participant Build as build.reflex.dev

    Note over NavBar,Build: Before (old behavior)
    User->>NavBar: Clicks "Sign In"
    NavBar->>Build: GET /cloud-login?redirect_to=.../callback/
    Build-->>User: Login page (then redirect to /callback/)

    Note over NavBar,Build: After (new behavior)
    User->>NavBar: Clicks "Sign In"
    NavBar->>Build: GET / (main page)
    Build-->>User: Main page (handles auth flow internally)
Loading

Last reviewed commit: "update login route t..."

@Alek99 Alek99 self-requested a review March 18, 2026 23:33
@Alek99 Alek99 merged commit c794d74 into main Mar 18, 2026
10 checks passed
@Alek99 Alek99 deleted the update-login-route-to-be-main-page branch March 18, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants