Skip to content

Include magpie Climate Change in NGFS-related runs#2301

Closed
lecfab wants to merge 1 commit intoremindmodel:developfrom
lecfab:ngfs
Closed

Include magpie Climate Change in NGFS-related runs#2301
lecfab wants to merge 1 commit intoremindmodel:developfrom
lecfab:ngfs

Conversation

@lecfab
Copy link
Contributor

@lecfab lecfab commented Mar 4, 2026

Purpose of this PR

New default in MAgPIE uses climate change impacts. For NGFS, each scenario is now associated with its RCP, and Climate Change impact is taken into account.
This PR merges de NGFS switches into default.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ☑️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

@lecfab lecfab requested review from dklein-pik and mishkos March 4, 2026 14:46
Copy link
Contributor

@mishkos mishkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that SSP2-NDC is used in other projects, not only NGFS. My intention was to include climate change impacts in MAgPIE only for NGFS. But since there is no clear distinction for the NDC scenario for NGFS and other projects, this will lead to inconsistency as other scenarios have nocc per default. Is it possible to make a distinct name for NGFS NDC scenario? And also for other commonly defined scearios which are also used in NGFS?

SSP2_lowEn-PkBudg650;0;;;SSP2|NDC|AR-natveg|nocc_hist;y2030;1;2025;2050;0.03;2025;2050;0.3;const2030;734;;0;0;2030;2030;2030
SSP2-EcBudg400;0;;;SSP2|NDC|AR-plant|nocc_hist;y2030;1;2050;2070;0.02;2050;2070;0.2;const2030;734;;0;0;2050;2040;2050
SSP2-NDC;0;;;SSP2|NDC|AR-natveg|nocc_hist|rcp4p5;y2150;1;;;0;;;0;const2030;734;;0;1;2030;2030;2030
SSP2-NDC;0;;;SSP2|NDC|AR-natveg|cc|rcp4p5;y2150;1;;;0;;;0;const2030;734;;0;1;2030;2030;2030
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that SSP2-NDC is used in other projects, not only NGFS. My intention was to include climate change impacts in MAgPIE only for NGFS. But since there is no clear distinction for the NDC scenario for NGFS and other projects, this will lead to inconsistency as other scenarios have nocc per default. Is it possible to make a distinct name for NGFS NDC scenario? And also for other commonly defined scearios which are also used in NGFS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep some switches separate between NGFS and default, if we have to (there are anyway two config files, because the title of scenarios differ).
But the general idea is that all choices that we make for "standard" NGFS runs (CP, NDC, 1.5°, 2°) should feed into the default.

Agreed that it's better to have consistency across default scenarios! But don't know if we want all of them to have CC or noCC... =) Who should decide on that?

@lecfab
Copy link
Contributor Author

lecfab commented Mar 6, 2026

@mishkos is discussing this further with @flohump.
Considering the sensitivity of changing this in default runs, let's close this PR for now and wait for a decision and plan!

@lecfab lecfab closed this Mar 6, 2026
@mishkos
Copy link
Contributor

mishkos commented Mar 6, 2026

@lecfab It was decided at the NGFS consortium meeting that we should go with no climate change impacts in the Ag sector. Eventually we can test sensitivity to cc in some scenarios. We will have to revert this change :/

@lecfab
Copy link
Contributor Author

lecfab commented Mar 6, 2026

@lecfab It was decided at the NGFS consortium meeting that we should go with no climate change impacts in the Ag sector. Eventually we can test sensitivity to cc in some scenarios. We will have to revert this change :/

Good to know thanks! So for the config, we can also remove the rcp tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants