Adapt global budget convergence criterion for runs with interalized damages#2302
Merged
laurinks merged 1 commit intoremindmodel:developfrom Mar 6, 2026
Merged
Conversation
Contributor
|
I don't see how this could cause a problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #1988.
Purpose of this PR
Adapt global budget convergence criterion for runs with internalized damages. If damages are internalized, it is only checked that the target budget is not exceeded. For example, if the target budget is 1000 Gt CO2 and the SCC is sufficiently high to imply that the carbon budget never exceeds 900 Gt CO2, the run should still converge.
Move the global budget convergence criterion into the
$ifthen.carbonprice %carbonprice% == "functionalForm"condition. This does not change anything since%carbonprice% != "functionalForm"impliessm_globalBudget_absDev = 0which implies that the criterion is anyway met. So it is only an aesthetic change to make it easier to understand the code by seeing that this convergence criterion is only relevant for the functionalForm realization.Requesting review from @fpiontek to check that this interacts with the damage module as intended, from @LaviniaBaumstark for general check, and from @tabeado to check that 2 does not create problems for functionalFormRegi. Thanks!
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)