Skip to content

Fix typegen support for routes outside appDirectory #14410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix typegen support for routes outside appDirectory #14410

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c31fff7
Show typegen behavior for routes outside appDirectory
alex-pex Oct 2, 2025
369ce68
Add typegen support for routes outside appDirectory
alex-pex Oct 2, 2025
f52d8af
tests: automatically create directories for `edit`s
pcattori Nov 13, 2025
0d0fa51
remove checks for exact typegen file locations
pcattori Nov 13, 2025
deb5de0
changeset
pcattori Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions integration/typegen-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import fs from "node:fs/promises";

import { expect } from "@playwright/test";
import tsx from "dedent";
import * as Path from "pathe";

Expand Down Expand Up @@ -337,7 +336,7 @@ test.describe("typegen", () => {
await $("pnpm typecheck");
});

test("routes outside app dir", async ({ cwd, edit, $ }) => {
test("routes outside app dir", async ({ edit, $ }) => {
await edit({
"react-router.config.ts": tsx`
export default {
Expand Down Expand Up @@ -374,14 +373,6 @@ test.describe("typegen", () => {
`,
});
await $("pnpm typecheck");

// Verify that the types file was generated in the correct location
const annotationPath = Path.join(
cwd,
".react-router/types/app/pages/+types/product.ts",
);
const annotation = await fs.readFile(annotationPath, "utf8");
expect(annotation).toContain("export namespace Route");
Copy link
Author

@alex-pex alex-pex Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you be sure .react-router/types/app/pages/+types/product.ts exists without the assertion?

Copy link
Contributor

@pcattori pcattori Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that file doesn't exist, then pnpm typecheck will fail

});

test("matches", async ({ edit, $ }) => {
Expand Down