Skip to content

bug reproduction: returned variable from fetch() is not an instance of global Response - #3480

Closed
manV wants to merge 3 commits into
remix-run:devfrom
manV:dev
Closed

manV wants to merge 3 commits into
remix-run:devfrom
manV:dev

Conversation

@manV

@manV manV commented Jun 15, 2022

Copy link
Copy Markdown
  • Docs
  • Tests

Testing Strategy:

The returned variable from fetch should be an instance of global variable Response but it does not seem to be the case.

however it seems to be an instance of Response from @remix-run/web-fetch

@remix-cla-bot

remix-cla-bot Bot commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

Hi @manV,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot

remix-cla-bot Bot commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@changeset-bot

changeset-bot Bot commented Jan 24, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3fc5d33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey

Copy link
Copy Markdown
Member

This will be fixed by #4148

@github-actions

github-actions Bot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants