You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An initial draft for the discussed vars function on the cycle object.
Works similar to :map in that you can supply either a static table or a function returning a table.
I guess we'll need a different context for vars? Since variables are only being assigned once per generate instead of for each event, the fields related to single steps are meaningless.
Here, the table variant inserts the variables to the cycle directly instead of passing around the table (contrary to the case with map) whereas the callback variant follows a similar pattern to the mapping_function.
Not sure what else should happen with the callback and its errors, but it seems to work fine so far.
Looks great. I'll add a few nitpicking comments in the review and will do more testing over the weekend. Else this looks straight forward and like a really great addition!
Hey, did you mean that you wanted to add those comments to this as-is, or are you waiting for me here to make the PR more complete? I'd appreciate any nitpicks here before continuing!
There should be a new with_variables_callback instead of adding this into the existing off-topic with_mapping_callback. I can fix that too if you want me to.
I've separated those and refactored the scripted cycle a bit, since the cycle either has a static table mapping or a callback (and a timeout hook always exist with a callback and never with a mapping), having these as an enum makes the code more self-explanatory.
Added a new kind of context for the variables callback that gets the parameters and the current iteration of the cycle assigned, do you think anything else would make sense here?
Updated the API docs and the guide with the var function example.
That looks great. Thanks. Give me some time to review and test this, as this is a larger change. Will do do ASAP beginning next week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial draft for the discussed
varsfunction on the cycle object.Works similar to
:mapin that you can supply either a static table or a function returning a table.I guess we'll need a different context for
vars? Since variables are only being assigned once pergenerateinstead of for each event, the fields related to single steps are meaningless.Here, the table variant inserts the variables to the cycle directly instead of passing around the table (contrary to the case with
map) whereas the callback variant follows a similar pattern to themapping_function.Not sure what else should happen with the callback and its errors, but it seems to work fine so far.