fix(collect): cluster resource errors json file has wrong name #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
emosbaugh
force-pushed
the
issue-1916-replicaset-errors
branch
from
8f4a271 to
2db307c
Compare
emosbaugh
force-pushed
the
issue-1916-replicaset-errors
branch
from
2db307c to
d2ae386
Compare
| "workflow_run_id": "19684723539", | ||
| "k8s_version": "v1.28.3", | ||
| "updated_by": "Ethan Mosbaugh <[email protected]>" | ||
| } |
There was a problem hiding this comment.
Bug: Accidentally committed baseline metadata file
The test/baselines/metadata.json file contains hardcoded values from a specific test run, including a timestamp, git SHA, workflow run ID, and user email. This file should be generated dynamically by the update_baselines.sh script rather than committed with specific values. The presence of this file suggests it was accidentally included from a local test run.
Member
Author
There was a problem hiding this comment.
i think i am supposed to commit this
Member
Author
|
Closing in favor of #1936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
The cluster resources collector is writing replicaset resources to a directory called statefulsets-errors.json, instead of replicasets.
Fixes: #1916
Also fixes issues:
./scripts/update_baselines.shgh run downloadcommand fails with "fatal not a git repository" errorChecklist
Does this PR introduce a breaking change?