fix(cli): restore the space in the dynamic-hint failure message - #1977
Open
RaghavChamadiya wants to merge 1 commit into
Open
fix(cli): restore the space in the dynamic-hint failure message#1977RaghavChamadiya wants to merge 1 commit into
RaghavChamadiya wants to merge 1 commit into
Conversation
The two adjacent string literals join with no separator, so the warning renders as "Dynamic edgeswill be missing from this update." It has read that way since #1772. Reported on #1772 by @Shivang9983.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two adjacent string literals in
_extract_dynamic_hintsjoin with no separator, so the warning renders as:packages/core/src/repowise/core/pipeline/incremental.py:217:The trailing space belongs on the first literal. One character.
Credit
Spotted by @Shivang9983 on #1772. I said on that thread I would take it rather than send them round again, so this is that.
Test Plan
ruff check .)grepovertests/for the message finds nothing)