docs(ui): stop claiming the theme toggle is shared with hosted - #2027
Open
RaghavChamadiya wants to merge 1 commit into
Open
docs(ui): stop claiming the theme toggle is shared with hosted#2027RaghavChamadiya wants to merge 1 commit into
RaghavChamadiya wants to merge 1 commit into
Conversation
The docstring described this component as the canonical implementation consumed by both packages/web and the hosted frontend, so that the toggle UX stays identical across surfaces. Only the first half is true. Hosted renders a single icon button of its own and has done for a while. The comment is the reason that went unnoticed: a shared component that names its consumers is the thing you check before assuming parity, and this one named a consumer it does not have. Replace the claim with what is actually there, including that the hosted control is the newer design and is meant to land here rather than stay forked. Comment only, no behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/ui/src/shared/theme-toggle.tsxopens by describing itself as theOnly the first half of that is true. The hosted app imports a local single-button toggle of its own and has done for a while, so the two surfaces do not match.
The comment is a good part of why that went unnoticed. A shared component that names its consumers is exactly the thing you check before assuming parity, and this one named a consumer it does not have.
This replaces the claim with what is actually there, and records that the hosted control is the newer design (it carries a focus ring and a reduced-motion guard this one lacks) and is meant to land here rather than stay forked.
Comment only. No behaviour change, no API change.