fix(postgres): widen git_function_blame.symbol_id to Text - #2169
Open
Aman-goel-04 wants to merge 1 commit into
Open
fix(postgres): widen git_function_blame.symbol_id to Text#2169Aman-goel-04 wants to merge 1 commit into
Aman-goel-04 wants to merge 1 commit into
Conversation
Aman-goel-04
requested review from
RaghavChamadiya and
swati510
as code owners
September 8, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git_function_blame.symbol_idfromVARCHAR(512)toText, it mirrorsWikiSymbol.symbol_id, which is already unbounded, but wasn't caught by [Bug] Postgres SQL Schema doesn't fit data for big projects, Phase 4 of 4 · Persistence fails #1565/0062since that migration targeted symbol name columns at 255 chars, not a symbol id at 5120064(Postgres-only, same shape as0062)Related Issues
Fixes #2162
Test Plan
pytest)ruff check .)npm run build) (no frontend changes)What was done
alembic upgrade head/downgrade -1verified round-trip on a stamped pre-fix schematests/integration/test_postgres_git_function_blame_symbol_id.py), confirmed it fails without the fix and passes with itChecklist