Skip to content

fix: add validations and processing logics to renderTemplate #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add validations and processing logics to renderTemplate #28

wants to merge 1 commit into from

Conversation

@nsrCodes
Copy link
Contributor

@nsrCodes nsrCodes commented Jan 7, 2025 •
edited
Loading

  • validate that params are present for helpers that require params
  • validate if the number of params present are equal to or greater than the minimum that are required
  • if any of the validations above fail, then escape this part of the template (i.e. not process as helper)
  • add quotes if not already added around the args for the helper functions (required in the syntax for specifying them in hbsTemplate

also renames the helper urlParam to urlParams

@nsrCodes
fix: add validations and processing logics to renderTemplate
babfbc8 
- validate that params are present for helpers that require params
- validate if the number of params present are equal to or greater than the minimum that are required
- if any of the validations above fail, then escape this part of the template (i.e. not process as helper)
- add quotes if not already added around the args for the helper functions (required in the syntax for specifying them in hbsTemplate
@nsrCodes nsrCodes requested a review from wrongsahil January 7, 2025 22:41
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wrongsahil wrongsahil Awaiting requested review from wrongsahil

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsrCodes @CLAassistant