Fix wrong key type in multipart decoder #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header is parsed into a CaseInsensitiveDict which keys are specified to be expected to be strings, but it was here set to bytes. https://github.com/psf/requests/blob/main/requests/structures.py#:~:text=All%20keys%20are%20expected%20to%20be%20strings.%20The%20structure%20remembers%20the This fix removes that encoding that converted the parsed key back to bytes.
|
Is this repo still active? I just came across this today and can confirm that it is still an issue. It would be nice to fix this annoying bug, especially as it is a recommended package by requests. |
Collaborator
|
There's no test for this fix to ensure it won't regress. The repository is still maintained but changes need tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header is parsed into a CaseInsensitiveDict which keys are specified to be strings, but it was here set to bytes. https://github.com/psf/requests/blob/51716c4ef390136b0d4b800ec7665dd5503e64fc/requests/structures.py#L20
This fix removes the encoding that converted the parsed keys back to bytes.