Skip to content

Conversation

@aedm
Copy link
Member

@aedm aedm commented Oct 28, 2025

Related

Part of #8948

What

  • Adds automated tests for deselecting items
  • Removes check_deselect_on_escape.py from release checklist

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Web viewer built successfully.

Result Commit Link Manifest
1d07bee https://rerun.io/viewer/pr/11685 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@aedm aedm changed the title Aedm/deselect on escape Test: deselect on escape Oct 28, 2025
@aedm aedm added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Oct 28, 2025
@aedm aedm marked this pull request as ready for review October 31, 2025 14:04
@aedm aedm requested a review from emilk October 31, 2025 14:04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"xtemp"?

@@ -0,0 +1,71 @@
use re_integration_test::HarnessExt as _;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use re_integration_test::HarnessExt as _;
//! Test that pressing the Escape key will back out of dialogs etc.
use re_integration_test::HarnessExt as _;

@aedm aedm merged commit 478ce73 into main Nov 14, 2025
71 of 72 checks passed
@aedm aedm deleted the aedm/deselect-on-escape branch November 14, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants