fix fast-groups toggle + widget sync in frontend (fast_actions/fast_groups_muter) #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- normalize widget boolean reads to use widget.toggled when present - prefer node.handleAction(action) for virtual actions and refresh widgets/service after - add sync scheduling to ensure UI state updates after programmatic changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a frontend bug in the RGTHREE custom nodes where the "Fast Actions" button and the "Fast Groups" widgets would not reliably toggle group enable/bypass state (the button seemed to toggle only once or behave directionally). The issue was caused by a mix of:
widget.value(an object) instead of theFastGroupsToggleRowWidgetboolean accessorwidget.toggled,handleAction, which can lead to stale UI widget state unless a recompute/refresh is run afterwards.Changes
widget.toggledif present, fallback towidget.value) infast_groups_muter.js.node.handleAction(action)from the Fast Actions button if the node implements it. After callinghandleAction, force a widget refresh and schedule the fast-groups service recompute to ensure UI state and internal group caches are synchronized.Files changed
Testing
toggleRestriction = "always one".See gif animation of the button working on latest comfyui version as of today