Skip to content

BUGFIX client plugin - #23

Open
PavolVican wants to merge 11 commits into
rh-lab-q:masterfrom
PavolVican:master
Open

BUGFIX client plugin #23
PavolVican wants to merge 11 commits into
rh-lab-q:masterfrom
PavolVican:master

Conversation

@PavolVican

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread client/dnf_zsync.py Outdated
outputs = awk.communicate()
if zsync.returncode or awk.returncode or self.print_log:
logger.debug(outputs[0].decode('utf-8'))
check_output(['rm', '-rf', input_file + '.part'])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.remove()

Comment thread client/dnf_zsync.py Outdated

def backup_files(self):
if self._backup_dir is None:
with tempfile.TemporaryDirectory() as tmpfile:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not going to work with python2 =(

Comment thread client/dnf_zsync.py Outdated
'/repodata/' + file], stdout=DEVNULL, stderr=DEVNULL)
except CalledProcessError as ex:
logger.debug(str(ex))
return 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to re-raise exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants