Skip to content

CheckCerts - Print out names of badroots in exception - #56

Merged
judovana merged 2 commits into
rh-openjdk:mainfrom
vieiro:feature/checkcerts-improvement
Nov 5, 2026
Merged

judovana merged 2 commits into
rh-openjdk:mainfrom
vieiro:feature/checkcerts-improvement

Conversation

@vieiro

@vieiro vieiro commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

When the CheckCerts.java test fails it doesn't say which badroots are failing.

This enhancements lists the names of the bad certs in the exception, so one can quickly see what the problem is.

Signed-off-by: Antonio Vieiro <avieirov@redhat.com>
@judovana

judovana commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Thanx! Highly appreciated. There are mixed tabs and sapces if you are willing to fix, would be nice, but not blocking it.
Is it worthy to add also to the https://github.com/vieiro/jtreg-buffer/blob/3e687bb25573002e9b87c35a7d60d5e6fe45307f/test/reproducers/emudra/CheckCertsStrict.java ?

@judovana judovana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • optional tabs2sapces
  • optional fix also to CheckCertsStrict.java

Signed-off-by: Antonio Vieiro <avieirov@redhat.com>
@vieiro

vieiro commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author
  • optional tabs2sapces

    • optional fix also to CheckCertsStrict.java

Done (hopefully).

@judovana

judovana commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

TYVVM!

@judovana
judovana merged commit 01e8ffd into rh-openjdk:main Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants