Error message#2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the error handling behavior across the codebase by replacing LogMessage with ErrorMessage and adjusting associated tests to reflect these changes.
- Updated test assertions in multiple test files
- Modified error message instantiation in serialization and transport classes
- Introduced a new constant LEVEL_JUNK in LogMessage for non-critical error logging
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/JsonMessageSerializerTest.php | Updated tests to expect ErrorMessage and improved error message contents |
| tests/Unit/IpcSessionTest.php | Modified test expectations to use ErrorMessage in error dispatch |
| tests/Unit/FrameCodecTest.php | Updated test assertions to expect ErrorMessage in frame deserialization errors |
| src/Transport/NativeFrameReader.php | Minor formatting change |
| src/Transport/FrameCodec.php | Switched error instantiation to ErrorMessage; adjusted log message for junk data |
| src/Serialization/JsonMessageSerializer.php | Replaced LogMessage with ErrorMessage for error return cases |
| src/NativeIpcPeer.php | Adjusted use statements and ordering |
| src/Message/LogMessage.php | Added constant LEVEL_JUNK |
| src/Message/ErrorMessage.php | Introduced new ErrorMessage implementation |
| src/IpcSession.php | Updated error handling in dispatch to use ErrorMessage |
| src/Envelope/ResponsePromise.php | Minor whitespace changes |
| src/AmphpIpcPeer.php | Adjusted use statement ordering |
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.