Generated license compliance reports are committed to git - #1216
Merged
Conversation
|
@Emoji-dot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1201
Task Complete ✓
I've successfully fixed the license compliance reports being committed to git. Here's what I did:
Changes Made:
Updated .gitignore: Added /compliance/reports/ to ignore the machine-generated license report files while preserving the configuration files.
Extended CI Guard: Updated
ci.yml
to include 'compliance/reports/' in the no-build-artifacts check alongside 'dist/' and '*.tsbuildinfo'.
Removed Existing Reports: Used git rm --cached to remove all 10 existing license report JSON files from git tracking.
Verification:
✅ Configuration files remain tracked (compliance/configs/,
deprecation-registry.json
,
README.md
)
✅ New license reports are automatically ignored by git
✅ CI guard properly detects if reports are accidentally committed
✅ License scanning still works correctly (npm run license:scan)
The CI will now prevent these machine-generated files from being committed in the future, and the existing reports have been removed from version control while preserving the important configuration files.