Skip to content

fix(storage): bound coverage cleanup batch #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fewensa merged 1 commit into from
Aug 16, 2026
Merged

fix(storage): bound coverage cleanup batch #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/storage/src/maintenance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use crate::{

const MAX_SPARSE_SOURCE_RANGES_PER_CANDIDATE: usize = 3;
const MAX_SPARSE_CANDIDATE_RANGE_SPAN_BLOCKS: u64 = 100_000;
const COVERAGE_INDEX_V2_CLEANUP_RECORDS_PER_TICK: usize = 32;
const COVERAGE_INDEX_V2_CLEANUP_RECORDS_PER_TICK: usize = 4;
const COVERAGE_INDEX_V2_BUCKET_SCAN_PAGES_PER_TICK: usize = 8;
const COVERAGE_INDEX_V2_QUEUE_RECORDS_PER_SCAN: usize = 8;

Expand Down
10 changes: 5 additions & 5 deletions crates/storage/tests/maintenance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4601,7 +4601,7 @@ fn test_compaction_coverage_index_v2_cleanup_scan_is_bounded() {
)
.expect("cleanup scan should be bounded");

assert_eq!(report.get_operations, 72);
assert_eq!(report.get_operations, 44);
assert_eq!(report.coverage_index_v2_deleted_deltas, 40);
}

Expand Down Expand Up @@ -4645,9 +4645,9 @@ fn test_compaction_coverage_index_v2_cleanup_scan_uses_capped_get_budget() {
)
.expect("cleanup scan should use available get budget");

assert_eq!(report.get_operations, 112);
assert_eq!(report.get_operations, 84);
assert_eq!(report.coverage_index_v2_deleted_deltas, 80);
assert_eq!(coverage_index_v2_cleanup_count(&storage, &chain), 48);
assert_eq!(coverage_index_v2_cleanup_count(&storage, &chain), 76);
}

#[test]
Expand Down Expand Up @@ -6124,8 +6124,8 @@ fn test_compaction_coverage_index_v2_cleanup_scan_preserves_hot_bucket_budget()
.expect("cleanup should not starve hot bucket compaction");

assert_eq!(report.coverage_index_v2_compacted_buckets, 1);
assert_eq!(report.coverage_index_v2_compacted_deltas, 96);
assert_eq!(report.get_operations, 128);
assert_eq!(report.coverage_index_v2_compacted_deltas, 100);
assert_eq!(report.get_operations, 104);
assert_eq!(
coverage_index_v2_snapshot_head_count_for_bucket(
&storage, &chain, scope, 25_400_000, 25_499_999,
Expand Down
Loading