Skip to content

fix(storage): shorten background s3 timeouts - #461

Merged
fewensa merged 1 commit into
mainfrom
agt/datalens-background-s3-timeout
Aug 16, 2026
Merged

fix(storage): shorten background s3 timeouts#461
fewensa merged 1 commit into
mainfrom
agt/datalens-background-s3-timeout

Conversation

@fewensa

@fewensa fewensa commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep foreground S3 operations at the existing 30s timeout
  • shorten background S3 operations to 5s so compaction/cleanup cannot sit on slow RustFS calls for minutes
  • add a unit test locking the foreground/background timeout split

Safety

  • query/read correctness is unchanged: foreground store keeps the 30s timeout
  • coverage max-delta guard is unchanged
  • background maintenance is retryable and will continue on later ticks after transient timeout failures

Tests

  • cargo fmt --check
  • cargo test -p datalens-storage test_s3_runtime -- --nocapture
  • cargo test -p datalens-storage test_s3_background_operations_have_shorter_timeout -- --nocapture
  • cargo test -p datalens-storage --test maintenance test_compaction_coverage_index_v2 -- --nocapture
  • cargo clippy -p datalens-storage --all-targets -- -D warnings

@fewensa
fewensa merged commit 294b088 into main Aug 16, 2026
1 check passed
@fewensa
fewensa deleted the agt/datalens-background-s3-timeout branch August 16, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant