Skip to content

Add Base Playground GTK faucet contract - #1119

Closed
fewensa wants to merge 2 commits into
mainfrom
agt/playground-faucet-contract
Closed

fewensa wants to merge 2 commits into
mainfrom
agt/playground-faucet-contract

Conversation

@fewensa

@fewensa fewensa commented Aug 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add a fixed-amount GTK faucet for the Base Playground DAO
  • enforce 100 GTK per address every 24 hours on-chain
  • add pause, withdrawal, deployment script, and Foundry tests

Rules

  • Base chain ID 8453 only
  • GTK token 0xef8ef3A1705f42e7FC1e06809940ec5942F5bB98
  • native Base ETH is not distributed
  • global limit 100,000 GTK per UTC day

Refs #1099

Copilot AI lite review requested due to automatic review settings August 30, 2026 04:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T04:45:54.396323Z 47d1ae3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47d1ae3a1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread contracts/test/PlaygroundFaucet.t.sol

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an on-chain GTK faucet for the Base Playground DAO, including a deploy script, documentation, and Foundry tests to enforce a fixed claim amount with a 24-hour per-address cooldown.

Changes:

  • Introduces PlaygroundFaucet contract with fixed-amount claims, cooldown tracking, pausing, and owner withdrawals.
  • Adds a Base-only deployment script with the fixed GTK token address.
  • Adds initial Foundry tests and updates the contracts README with faucet details and deployment instructions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
contracts/src/PlaygroundFaucet.sol New faucet contract implementing fixed claims, cooldown, pausing, and withdrawals.
contracts/script/PlaygroundFaucet.s.sol New Foundry deployment script restricted to Base chain ID and fixed GTK address.
contracts/test/PlaygroundFaucet.t.sol New unit tests covering claim amount, cooldown behavior, pausing, and withdraw access control.
contracts/README.md Documents faucet parameters and deployment command.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread contracts/script/PlaygroundFaucet.s.sol
Comment thread contracts/src/PlaygroundFaucet.sol Outdated
@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

@fewensa
fewensa force-pushed the agt/playground-faucet-contract branch from 47d1ae3 to ed897e1 Compare August 30, 2026 04:48
@fewensa

fewensa commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Closing without merging because the Faucet contract architecture is no longer used. The approved implementation transfers GTK directly from a backend-managed distribution account in ringecosystem/degov-apps#336.

@fewensa fewensa closed this Sep 1, 2026
@fewensa
fewensa deleted the agt/playground-faucet-contract branch September 24, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants