-
Notifications
You must be signed in to change notification settings - Fork 41
Lending Protocol #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Lending Protocol #156
Conversation
maria-robobug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, just adding my initial pass of review comments.
I think there have been some recent changes in the spec that need to be reflected in the docs.
docs/xls-66d-lending-protocol/reference/transactions/loanmanage.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/loanset.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/loanset.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/loanset.md
Outdated
Show resolved
Hide resolved
c626eb1 to
597eb9b
Compare
Co-authored-by: Maria Shodunke <[email protected]>
Update sidebars.yaml to remove deleted file which was causing a broken link
docs/xls-66d-lending-protocol/use-cases/institutional-credit-facilities.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/use-cases/institutional-credit-facilities.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/use-cases/institutional-credit-facilities.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/use-cases/institutional-credit-facilities.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/updated-transactions.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/updated-transactions.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/ledger-data/loanbroker.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/use-cases/institutional-credit-facilities.md
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/loanbrokercoverclawback.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/loanbrokercoverclawback.md
Outdated
Show resolved
Hide resolved
docs/xls-66d-lending-protocol/reference/transactions/loanbrokercoverwithdraw.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Maria Shodunke <[email protected]>
Co-authored-by: Maria Shodunke <[email protected]>
…acilities.md Co-authored-by: Maria Shodunke <[email protected]>
…rcoverclawback.md Co-authored-by: Maria Shodunke <[email protected]>
…rcoverclawback.md Co-authored-by: Maria Shodunke <[email protected]>
maria-robobug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Concept and reference docs for the lending protocol.
Docs are based off this version of the XLS-66d spec.
Tentative Release to devnet: Nov 18.
Reviewer suggestions to add: