fix(ci): repair sync-amendments workflow and create missing script - #26
Closed
shichengripple001 wants to merge 1 commit into
Closed
fix(ci): repair sync-amendments workflow and create missing script#26shichengripple001 wants to merge 1 commit into
shichengripple001 wants to merge 1 commit into
Conversation
- Fix YAML syntax error (unindented multi-line --body broke the literal block) - Replace dead CLI command (`node --local --persist --detach` → `start --detach`) - Add `stop` cleanup step with `if: always()` - Use heredoc for PR body to avoid YAML/shell escaping issues - Create scripts/update-genesis-amendments.ts: queries mainnet for enabled amendments, filters to those supported by local rippled, appends new entries to [amendments] block in src/core/compose.ts before # sync:end Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sync-amendments.ymlworkflow has been broken since creation:--bodycontent dropped to zero indentation, breaking the YAML literal blocknode --local --persist --detachno longer exists (nowstart --detach)scripts/update-genesis-amendments.tswas never createdThis PR fixes all three:
<<'BODY') for the PR body, avoiding shell/YAML escaping issuesnode --local --persist --detachwithstart --detachstopcleanup step withif: always()so Docker containers don't leakscripts/update-genesis-amendments.tswhich:wss://xrplcluster.com) and callsfeatureRPC for all enabled amendmentsws://localhost:6006) and callsfeatureRPC for supported amendments[amendments]block insrc/core/compose.tsbefore# sync:endTest plan
workflow_dispatchand verify it runs without YAML errors🤖 Generated with Claude Code