fix: update Flatpak runtime from 23.08 to 24.08#133
Open
Conversation
The org.freedesktop.Platform 23.08 runtime is end-of-life and no longer receiving security updates. Update to 24.08 which is the current stable runtime version. Fixes #132
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| - | | ||
| set -e | ||
| VERSION=$(git describe --tags --always | sed 's/^[vV]//') |
There was a problem hiding this comment.
Shallow clone breaks git describe version resolution
Medium Severity
The git source uses depth: 1 (shallow clone), but the post-install script relies on git describe --tags --always to resolve the version. Shallow clones don't reliably include tag refs or traversable history, so git describe --tags fails to find the v1.5.0 tag. The --always fallback silently produces an abbreviated commit hash (e.g., abc1234) instead of the version string 1.5.0, causing incorrect @VERSION@ substitution in the metainfo XML.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.freedesktop.Platformruntime from end-of-life version23.08to current stable24.08pkg/flatpak/so it's maintained alongside the source codeFixes #132
Test plan
flatpak-builder build-dir pkg/flatpak/xyz.xclicker.xclicker.ymlflatpak updateno longer shows end-of-life warningsNote
Low Risk
Low risk: adds a Flatpak manifest and updates the runtime version; no changes to application runtime logic beyond packaging/build behavior.
Overview
Adds a new Flatpak manifest at
pkg/flatpak/xyz.xclicker.xclicker.ymland moves the app’s Flatpak build definition into this repo.The manifest targets
org.freedesktop.Platform24.08 (up from the previous 23.08 per PR description), installs the builtxclickerbinary plus desktop/metainfo/icon assets, and post-processes metainfo placeholders with the current git-derived version/date.Written by Cursor Bugbot for commit 0190b8d. This will update automatically on new commits. Configure here.