fix #807 #821: add --packet-encoding and --packet-mtu to roc-send#837
Open
Ayoub-glitsh wants to merge 1 commit intoroc-streaming:masterfrom
Open
fix #807 #821: add --packet-encoding and --packet-mtu to roc-send#837Ayoub-glitsh wants to merge 1 commit intoroc-streaming:masterfrom
Ayoub-glitsh wants to merge 1 commit intoroc-streaming:masterfrom
Conversation
…packet-mtu to roc-send - Add --packet-encoding option to roc-send (e.g. 96:s16/48000/stereo) Registers a custom RTP payload type in the encoding map and sets it as the sender payload type. When the encoding rate matches the input rate, no resampler is created, fixing issue roc-streaming#807. - Add --packet-mtu option to roc-send When --packet-len is not set, packet_length is auto-derived from the MTU using the encoding's sample spec. When both are set, the smaller value is used with a warning. Fixes issue roc-streaming#821. - Add packet_mtu field to SenderSinkConfig - Derive effective_packet_length in sender_session before packetizer init
|
🤖 Pull request is not targeted to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --packet-encoding option to roc-send (e.g. 96:s16/48000/stereo) Registers a custom RTP payload type in the encoding map and sets it as the sender payload type. When the encoding rate matches the input rate, no resampler is created, fixing issue Can't disable resampling with rec-send command line #807.
Add --packet-mtu option to roc-send When --packet-len is not set, packet_length is auto-derived from the MTU using the encoding's sample spec. When both are set, the smaller value is used with a warning. Fixes issue Multitrack packets too big per default ("packetizer: can't prepare packet") #821.
Add packet_mtu field to SenderSinkConfig
Derive effective_packet_length in sender_session before packetizer init