Initial Handshake Implementation - #14
Open
AcoSmrkas wants to merge 20 commits into
Open
Conversation
|
@AcoSmrkas is attempting to deploy a commit to the rosen-bridge Team on Vercel. A member of the Team first needs to authorize it. |
abdolian
reviewed
May 12, 2026
|
What's holding this up? |
# Conflicts: # apps/rosen-service/config/default.yaml # apps/rosen-service/package.json # apps/rosen-service/src/calculator/calculator-service.ts # apps/rosen-service/src/configs.ts # apps/rosen-service/src/constants.ts # apps/rosen-service/src/event-trigger/event-trigger-service.ts # apps/rosen-service/src/health-check/health-check-service.ts # apps/rosen-service/src/observation/observation-service.ts # apps/rosen-service/src/scanner/scanner-service.ts # apps/rosen-service2/src/services/assetAggregator.ts # apps/rosen-service2/src/services/assetDataAdapters.ts # apps/rosen/package.json # build.sh # knip.config.ts # package-lock.json # packages/asset-calculator/lib/asset-calculator.ts # packages/asset-calculator/lib/interfaces.ts # packages/asset-calculator/tests/asset-calculator.spec.ts # packages/constants/src/index.ts # packages/utils/src/getAddressUrl.ts # packages/utils/src/getTokenUrl.ts # packages/utils/src/getTxUrl.ts
getaddressbalance is not an hsd RPC method; both the full node (api.handshakeapi.com) and the ergexplorer proxy reject it. Query the address-indexed REST endpoint instead and sum the plain coins. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
api.handshakeapi.com is being retired. hsd.ergexplorer.com serves both the scanner RPC methods and the address-indexed coin endpoint the calculator needs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
I reviewed this merge request, and some comments have not been resolved yet. |
Author
|
My bad @abdolian ! |
- Drop the client re-export from the network package entry point so the server bundle no longer pulls in client-side logic; consumers already deep import from dist/client. - Remove fixed width/height from the Shake icon so it scales with its container, matching every other wallet icon. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Author
|
@abdolian patched. kindly review. thanks |
Collaborator
|
As you can see, the network tokens have a circular background, but the Handshake SVG does not. Please update the SVG icon to make it consistent with our design. 
|
Match the other network icons: 24x24 viewBox with a white backing circle and a full-bleed brand disc, with the HNS mark centred and sized in line with the rest of the set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Author
|
@abdolian kindly check the updated icon now. thanks |
# Conflicts: # packages/icons/src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation following RCS-003 - https://github.com/rosen-bridge/rcs/tree/master/rcs-003