feat: support X-Amp-Thread-Id for session affinity#2972
Open
XYenon wants to merge 2 commits intorouter-for-me:devfrom
Open
feat: support X-Amp-Thread-Id for session affinity#2972XYenon wants to merge 2 commits intorouter-for-me:devfrom
XYenon wants to merge 2 commits intorouter-for-me:devfrom
Conversation
|
This pull request targeted The base branch has been automatically changed to |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the X-Amp-Thread-Id header as a new source for session ID extraction, ranking it third in priority. The changes include updates to the extraction logic in extractSessionIDs, corresponding documentation updates, and new unit tests to verify both the extraction and its priority relative to other identifiers. Feedback suggests standardizing the header name to X-Amp-Thread-ID (capitalized 'ID') to maintain consistency with Go naming conventions and existing headers like X-Session-ID.
… read X-Amp-Thread-Id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support extracting X-Amp-Thread-Id header as session id for session affinity