Skip to content

Conversation

@jan-kolarik
Copy link
Member

Exclude replacing lines from the transaction table output when replacing a single package with the same name.

For #326.

Exclude `replacing` lines from the transaction table output when replacing a single package with the same name.
@jan-kolarik jan-kolarik force-pushed the jkolarik/drop-replacing-lines branch from 816f545 to 55c0eba Compare July 4, 2024 08:38
@jrohel
Copy link
Contributor

jrohel commented Jul 8, 2024

I understand the motivation for this change - fewer rows in the table.
The problem is that useful information is being removed, not just duplicated as stated in the linked issue.

For example, I check from which version to which version the change is happening before approving the upgrade.
Occasionally it happens that a package is replaced by a package with a different architecture, an arch package for noarch and vice versa. Or a package from a different repository.

I understand that not everyone checks what is happening in the system during an upgrade. But I do use this information and it is one of the reasons for me why dnf5 is better than dnf.

I guess we'll have to figure out the "verbosity" of the output somehow, since everyone has different preferences. This PR will satisfy users who want a shorter output at the expense of information (or who have super memory and know exactly what versions and from where they have installed and thus don't need to display it). But it will annoy those who are interested in details. Especially when I manage several different computers I am interested in the exact state of the upgraded computer when upgrading.

@jan-kolarik
Copy link
Member Author

There is an intent to have the verbosity configurable with a default level "not detailed". The verbose mode should be implemented by the #1518 after the discussion in #1191.

@jan-kolarik jan-kolarik added the blocked Further work on issue or PR is blocked by something else label Jul 22, 2024
@jan-kolarik
Copy link
Member Author

There isn't a consensus within the team on this approach. Let's wait until things settle around the verbose mode, and then we can decide. We can eventually merge it together when the verbose option is ready.

@ewoks
Copy link

ewoks commented Nov 15, 2024

Hi @jan-kolarik although there is no concensus about verbose mode, additional replacing line (even for exact replacements) became default way even without using --verbose.
If team really believe that this is necessary, let's please find a solution for many annoyed users and allow to turn this off (or make it simpler like with dnf4) by adding new flag --simple-out (or simial) even if it's default.

Would that be a compromise approach team can live with?

@ewoks
Copy link

ewoks commented Nov 22, 2024

@jan-kolarik can you please shine some light on the status? more and more tickets on this topic are open, it would be great to point users to one place with up-to-date info to manage expectations. Thanks :)

@jan-kolarik
Copy link
Member Author

@jan-kolarik can you please shine some light on the status? more and more tickets on this topic are open, it would be great to point users to one place with up-to-date info to manage expectations. Thanks :)

As of now, I can't provide specific details about this. It's on our radar, and we plan to implement verbose mode and make some changes to the default output—though preferably minimal compared to the current state (mainly wrt "replacing" things). I see this as more of a Q1 2025 or later task, as we're currently overwhelmed with higher-priority work.

@ferdnyc
Copy link
Contributor

ferdnyc commented Jan 17, 2025

As an in-betweening of this, in #785 (comment) I suggested changing the "replacing" line format for same-package replacements from:

<package_name>             <arch> <new_version>   <repo> <size>
  replacing <package_name> <arch> <old_version>   <repo> <size>

to:

<package_name>             <arch> <new_version>   <repo> <size>
  replacing                       <old_version>

Which would help with the line-wrapping issues frequently caused by the overly-long "␣␣replacing <package_name>" lines in the first column.

We would like to switch to exclusively using Packit for building and
testing pull requests, so we are retiring this GitHub Action workflow.
We will want to configure Packit to check that DNF5 compiles with both
GCC and clang, like the Package Build action did.

In order to fully disable the action, this commit must be applied on
each branch in the upstream DNF5 repository. Otherwise, the action might
be triggered by a pull request to some stale branch.
@evan-goode evan-goode requested a review from a team as a code owner June 12, 2025 19:42
@evan-goode evan-goode requested review from pkratoch and removed request for a team June 12, 2025 19:42
@ewoks
Copy link

ewoks commented Jun 15, 2025

@evan-goode failed and it looks like it contains more than you wanted to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Further work on issue or PR is blocked by something else

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

6 participants