Potential fix for code scanning alert no. 11: Workflow does not contain permissions#369
Draft
zeel-codder wants to merge 1 commit intodevelopfrom
Draft
Potential fix for code scanning alert no. 11: Workflow does not contain permissions#369zeel-codder wants to merge 1 commit intodevelopfrom
zeel-codder wants to merge 1 commit intodevelopfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/rtCamp/Frappe-Manager/security/code-scanning/11
In general, the problem is fixed by explicitly declaring a minimal
permissionsblock so theGITHUB_TOKENhas only the scopes required. For a test workflow like this that only needs to read the repository contents and interact with caches and artifacts,contents: readis sufficient; no write permissions are required.The best way to fix this without changing behavior is to add a root-level
permissionsblock to.github/workflows/e2e-site.yamlso it applies to all jobs (check-permissionsande2e-current). Place it near the top of the file, aftername:and beforeon:. Setpermissions: contents: read, which allowsactions/checkoutand the other actions to work, while preventing unnecessary write access to repository contents or other resources. No additional methods, imports, or definitions are needed since this is a YAML configuration change only.Suggested fixes powered by Copilot Autofix. Review carefully before merging.