Skip to content

Add DependencyExtractionWebpackPlugin for pages and read deps from .min.asset.php #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KMchaudhary wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add DependencyExtractionWebpackPlugin for pages and read deps from .min.asset.php #1964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 39 additions & 6 deletions inc/classes/class-assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,22 @@ protected function setup_hooks() {
*/
public function enqueue_scripts() {

$main_asset_file = RTGODAM_PATH . 'assets/build/js/main.min.asset.php';
$main_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/js/main.min.js' ),
);

if ( file_exists( $main_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$main_asset = include $main_asset_file;
}

wp_register_script(
'rtgodam-script',
RTGODAM_URL . 'assets/build/js/main.min.js',
array(),
filemtime( RTGODAM_PATH . 'assets/build/js/main.min.js' ),
$main_asset['dependencies'],
$main_asset['version'],
true
);

Expand Down Expand Up @@ -179,11 +190,22 @@ public function admin_enqueue_scripts() {
wp_enqueue_media();
}

$admin_asset_file = RTGODAM_PATH . 'assets/build/js/admin.min.asset.php';
$admin_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/js/admin.min.js' ),
);

if ( file_exists( $admin_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$admin_asset = include $admin_asset_file;
}

wp_register_script(
'rtgodam-script',
RTGODAM_URL . 'assets/build/js/admin.min.js',
array(),
filemtime( RTGODAM_PATH . 'assets/build/js/admin.min.js' ),
$admin_asset['dependencies'],
$admin_asset['version'],
true
);

Expand Down Expand Up @@ -331,11 +353,22 @@ public function admin_enqueue_scripts() {

// Only enqueue HTTP auth detector on uploads page or pages where media uploading is possible.
if ( godam_should_load_auth_detector_script( $screen ) ) {
$http_auth_asset_file = RTGODAM_PATH . 'assets/build/js/http-auth-detector.min.asset.php';
$http_auth_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/js/http-auth-detector.min.js' ),
);

if ( file_exists( $http_auth_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$http_auth_asset = include $http_auth_asset_file;
}

wp_register_script(
'godam-http-auth-detector',
RTGODAM_URL . 'assets/build/js/http-auth-detector.min.js',
array( 'jquery' ),
filemtime( RTGODAM_PATH . 'assets/build/js/http-auth-detector.min.js' ),
$http_auth_asset['dependencies'],
$http_auth_asset['version'],
Comment on lines 367 to +371
true
);

Expand Down
15 changes: 13 additions & 2 deletions inc/classes/class-deactivation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,22 @@ public function __construct() {
public function load_scripts() {
global $pagenow;

$deactivation_asset_file = RTGODAM_PATH . 'assets/build/js/deactivation-feedback.min.asset.php';
$deactivation_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/js/deactivation-feedback.min.js' ),
);

if ( file_exists( $deactivation_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$deactivation_asset = include $deactivation_asset_file;
}

wp_register_script(
'godam-deactivation-survey-script',
RTGODAM_URL . 'assets/build/js/deactivation-feedback.min.js',
array( 'wp-i18n' ),
filemtime( RTGODAM_PATH . 'assets/build/js/deactivation-feedback.min.js' ),
$deactivation_asset['dependencies'],
$deactivation_asset['version'],
true
);

Expand Down
19 changes: 13 additions & 6 deletions inc/classes/class-elementor-widgets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,22 @@ public function register_scripts() {
);


$elementor_frontend_asset_file = RTGODAM_PATH . 'assets/build/js/godam-elementor-frontend.min.asset.php';
$elementor_frontend_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/js/godam-elementor-frontend.min.js' ),
);

if ( file_exists( $elementor_frontend_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$elementor_frontend_asset = include $elementor_frontend_asset_file;
}

wp_register_script(
'godam-elementor-frontend',
RTGODAM_URL . 'assets/build/js/godam-elementor-frontend.min.js',
array(
'jquery',
'wp-i18n',
'godam-player-frontend-script',
),
filemtime( RTGODAM_PATH . 'assets/build/js/godam-elementor-frontend.min.js' ),
array_merge( $elementor_frontend_asset['dependencies'], array( 'godam-player-frontend-script' ) ),
$elementor_frontend_asset['version'],
true
);
}
Expand Down
135 changes: 117 additions & 18 deletions inc/classes/class-pages.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,22 @@ public function admin_enqueue_scripts() {

if ( $screen && in_array( $screen->id, array( $this->menu_page_id, $this->video_editor_page_id, $this->analytics_page_id, $this->settings_page_id, $this->help_page_id, $this->tools_page_id, $this->whats_new_page_id ), true ) ) {

$page_css_asset_file = RTGODAM_PATH . 'assets/build/pages/page-css.min.asset.php';
$page_css_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/page-css.min.js' ),
);

if ( file_exists( $page_css_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$page_css_asset = include $page_css_asset_file;
}

wp_register_script(
'rtgodam-page-style',
RTGODAM_URL . 'assets/build/pages/page-css.min.js',
array( 'wp-components' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/page-css.min.js' ),
$page_css_asset['dependencies'],
$page_css_asset['version'],
true
);

Expand All @@ -462,11 +473,22 @@ public function admin_enqueue_scripts() {
}
// Check if this is your custom admin page.
if ( $screen && $this->video_editor_page_id === $screen->id ) {
$video_editor_asset_file = RTGODAM_PATH . 'assets/build/pages/video-editor.min.asset.php';
$video_editor_asset = array(
'dependencies' => array( 'wp-element', 'wp-i18n' ),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/video-editor.min.js' ),
);

if ( file_exists( $video_editor_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$video_editor_asset = include $video_editor_asset_file;
}

wp_register_script(
'transcoder-page-script-video-editor',
RTGODAM_URL . 'assets/build/pages/video-editor.min.js',
array( 'wp-element', 'wp-i18n' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/video-editor.min.js' ),
$video_editor_asset['dependencies'],
$video_editor_asset['version'],
true
);

Expand Down Expand Up @@ -653,11 +675,22 @@ public function admin_enqueue_scripts() {
false
);

$dashboard_asset_file = RTGODAM_PATH . 'assets/build/pages/dashboard.min.asset.php';
$dashboard_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/dashboard.min.js' ),
);

if ( file_exists( $dashboard_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$dashboard_asset = include $dashboard_asset_file;
}

wp_register_script(
'godam-page-script-dashboard',
RTGODAM_URL . 'assets/build/pages/dashboard.min.js',
array( 'wp-element' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/dashboard.min.js' ),
$dashboard_asset['dependencies'],
$dashboard_asset['version'],
true
);

Expand Down Expand Up @@ -728,11 +761,22 @@ public function admin_enqueue_scripts() {
false
);

$analytics_asset_file = RTGODAM_PATH . 'assets/build/pages/analytics.min.asset.php';
$analytics_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/analytics.min.js' ),
);

if ( file_exists( $analytics_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$analytics_asset = include $analytics_asset_file;
}

wp_register_script(
'transcoder-page-script-analytics',
RTGODAM_URL . 'assets/build/pages/analytics.min.js',
array( 'wp-element', 'wp-i18n' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/analytics.min.js' ),
$analytics_asset['dependencies'],
$analytics_asset['version'],
true
);

Expand Down Expand Up @@ -866,11 +910,22 @@ public function admin_enqueue_scripts() {
wp_enqueue_script( 'transcoder-page-script-analytics' );
wp_enqueue_script( 'd3-js' );
} elseif ( $screen && $this->help_page_id === $screen->id ) {
$help_asset_file = RTGODAM_PATH . 'assets/build/pages/help.min.asset.php';
$help_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/help.min.js' ),
);

if ( file_exists( $help_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$help_asset = include $help_asset_file;
}

wp_register_script(
'godam-page-script-help',
RTGODAM_URL . 'assets/build/pages/help.min.js',
array( 'wp-element' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/help.min.js' ),
$help_asset['dependencies'],
$help_asset['version'],
true
);

Expand Down Expand Up @@ -900,11 +955,22 @@ public function admin_enqueue_scripts() {
wp_set_script_translations( 'godam-page-script-help', 'godam', RTGODAM_PATH . 'languages' );
wp_enqueue_script( 'godam-page-script-help' );
} elseif ( $screen && $this->settings_page_id === $screen->id ) {
$godam_asset_file = RTGODAM_PATH . 'assets/build/pages/godam.min.asset.php';
$godam_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/godam.min.js' ),
);

if ( file_exists( $godam_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$godam_asset = include $godam_asset_file;
}

wp_register_script(
'transcoder-page-script-godam',
RTGODAM_URL . 'assets/build/pages/godam.min.js',
array( 'wp-element', 'wp-i18n', 'wp-api-fetch' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/godam.min.js' ),
$godam_asset['dependencies'],
$godam_asset['version'],
true
);

Expand Down Expand Up @@ -992,11 +1058,22 @@ public function admin_enqueue_scripts() {
do_action( 'godam_enqueue_settings_page_scripts' );
} elseif ( $screen && $this->tools_page_id === $screen->id ) {

$tools_asset_file = RTGODAM_PATH . 'assets/build/pages/tools.min.asset.php';
$tools_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/tools.min.js' ),
);

if ( file_exists( $tools_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$tools_asset = include $tools_asset_file;
}

wp_register_script(
'godam-page-script-tools',
RTGODAM_URL . 'assets/build/pages/tools.min.js',
array( 'wp-element', 'wp-i18n' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/tools.min.js' ),
$tools_asset['dependencies'],
$tools_asset['version'],
true
);

Expand Down Expand Up @@ -1028,11 +1105,22 @@ public function admin_enqueue_scripts() {
wp_enqueue_script( 'godam-page-script-tools' );
} elseif ( $screen && $this->whats_new_page_id === $screen->id ) {

$whats_new_asset_file = RTGODAM_PATH . 'assets/build/pages/whats-new.min.asset.php';
$whats_new_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/whats-new.min.js' ),
);

if ( file_exists( $whats_new_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$whats_new_asset = include $whats_new_asset_file;
}

wp_register_script(
'godam-page-script-whats-new',
RTGODAM_URL . 'assets/build/pages/whats-new.min.js',
array( 'wp-element', 'wp-i18n' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/whats-new.min.js' ),
$whats_new_asset['dependencies'],
$whats_new_asset['version'],
true
);

Expand All @@ -1057,11 +1145,22 @@ public function admin_enqueue_scripts() {

wp_enqueue_style( 'wp-components' );

$media_library_asset_file = RTGODAM_PATH . 'assets/build/pages/media-library.min.asset.php';
$media_library_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/pages/media-library.min.js' ),
);

if ( file_exists( $media_library_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$media_library_asset = include $media_library_asset_file;
}

wp_register_script(
'media-library-react',
RTGODAM_URL . 'assets/build/pages/media-library.min.js',
array( 'wp-element', 'wp-i18n' ),
filemtime( RTGODAM_PATH . 'assets/build/pages/media-library.min.js' ),
$media_library_asset['dependencies'],
$media_library_asset['version'],
true
);

Expand Down
15 changes: 13 additions & 2 deletions inc/classes/class-video-embed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,22 @@ public function enqueue_video_embed_assets() {
);

// Enqueue script for the video embed page.
$video_embed_asset_file = RTGODAM_PATH . 'assets/build/js/godam-video-embed.min.asset.php';
$video_embed_asset = array(
'dependencies' => array(),
'version' => filemtime( RTGODAM_PATH . 'assets/build/js/godam-video-embed.min.js' ),
);

if ( file_exists( $video_embed_asset_file ) ) {
// phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingVariable -- file path is constant.
$video_embed_asset = include $video_embed_asset_file;
}

wp_register_script(
'godam-video-embed-script',
RTGODAM_URL . 'assets/build/js/godam-video-embed.min.js',
array(),
filemtime( RTGODAM_PATH . 'assets/build/js/godam-video-embed.min.js' ),
$video_embed_asset['dependencies'],
$video_embed_asset['version'],
true
);
}
Expand Down
Loading
Loading