fix(npx): route unknown packages directly via npx, not npm run#1293
Closed
NEOFIT-dev wants to merge 1 commit intortk-ai:developfrom
Closed
fix(npx): route unknown packages directly via npx, not npm run#1293NEOFIT-dev wants to merge 1 commit intortk-ai:developfrom
NEOFIT-dev wants to merge 1 commit intortk-ai:developfrom
Conversation
Unknown npx packages like vue-tsc were routed to npm_cmd::run which injects "run" before unrecognised first arguments, turning `rtk npx vue-tsc --noEmit` into `npm run vue-tsc --noEmit`. Add run_npx() that calls `npx <args>` directly and use it as the default handler in Commands::Npx. Fixes rtk-ai#1269
Collaborator
|
Closing as #1458 already fixed the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rtk npx vue-tsc --noEmitwas callingnpm run vue-tsc --noEmitinstead ofnpx vue-tsc --noEmit, producingnpm error Missing script: "vue-tsc".Root cause: the default
Commands::Npxhandler callednpm_cmd::run()which injectsrunbefore any argument not found inNPM_SUBCOMMANDS. Sincevue-tscis not in that list, it becamenpm run vue-tsc.Note:
rtk npx vue-tsc --versionappeared to work by accident — npm silently consumes--versionas its own flag rather than passing it to the script.Fix
Add
npm_cmd::run_npx()that callsnpx <args>directly without anyruninjection, and use it as the default handler for unknown packages inCommands::Npx.Testing
Fixes #1269