Skip to content

Fix/issue 1465#1488

Open
nhamtrieu wants to merge 16 commits intortk-ai:developfrom
nhamtrieu:fix/issue-1465
Open

Fix/issue 1465#1488
nhamtrieu wants to merge 16 commits intortk-ai:developfrom
nhamtrieu:fix/issue-1465

Conversation

@nhamtrieu
Copy link
Copy Markdown

@nhamtrieu nhamtrieu commented Apr 24, 2026

  • Introduced derive_init_targets function to streamline the installation logic for agents, allowing for more flexible target selection.
  • Updated the default behavior of rtk init to install Claude by default unless specified otherwise.
  • Added tests to verify the correct installation behavior based on agent selection.
  • Improved documentation in supported-agents.md to reflect the new installation options.

Summary

  • Refactored rtk init target selection into a dedicated helper in main so behavior is explicit and consistent (Claude by default, --opencode disables Claude, explicit targets install only the selected integration).
  • Improved hook/tracking reliability by ensuring parent directories exist before atomic writes and by making tracking tests deterministic with unique command keys plus direct DB assertions.

Test plan

  • cargo fmt --all && cargo clippy --all-targets && cargo test
  • Manual testing: rtk <command> output inspected

Important: All PRs must target the develop branch (not master).
See CONTRIBUTING.md for details.

aeppling and others added 10 commits April 17, 2026 09:44
…master--components--rtk

chore(master): release 0.37.0
…master--components--rtk

chore(master): release 0.37.1
…master--components--rtk

chore(master): release 0.37.2
- Introduced `derive_init_targets` function to streamline the installation logic for agents, allowing for more flexible target selection.
- Updated the default behavior of `rtk init` to install Claude by default unless specified otherwise.
- Added tests to verify the correct installation behavior based on agent selection.
- Improved documentation in `supported-agents.md` to reflect the new installation options.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 24, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ aeppling
✅ nhamtrieu
❌ github-actions[bot]
❌ rtk-release-bot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak pszymkowiak added bug Something isn't working effort-medium 1-2 jours, quelques fichiers enhancement New feature or request labels Apr 24, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟡 Risk medium

Summary

Refactors rtk init target selection into a dedicated derive_init_targets helper so Claude is installed by default unless --opencode or a specific agent target is passed. Also fixes hook reliability by ensuring parent directories exist before atomic writes, and makes tracking tests deterministic with unique command keys and direct DB assertions.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #1465


Analyzed automatically by wshm · This is an automated analysis, not a human review.

@thalesreisbr
Copy link
Copy Markdown

Hi @nhamtrieu @pszymkowiak

Is there any alternative way to work around the problem until the fix is ​​implemented?

@nhamtrieu
Copy link
Copy Markdown
Author

@thalesreisbr I haven’t tried it yet, but you can try creating a .claude directory to see if it works.

@nhamtrieu nhamtrieu marked this pull request as draft May 4, 2026 08:01
@nhamtrieu nhamtrieu marked this pull request as ready for review May 4, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort-medium 1-2 jours, quelques fichiers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants